<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">Can you try again after this commit?</div><div class=""><br class=""></div><div class=""> commit 9949cfbd05a076ee4b70e393c5da49dce640a3c7</div><div class=""> Author: Louis Dionne <<a href="mailto:ldionne@apple.com" class="">ldionne@apple.com</a>></div><div class=""> Date: Tue Apr 7 08:56:30 2020 -0400</div><div class=""><br class=""></div><div class=""> [libc++] Make sure the source file appears before link libraries when compiling tests</div><div class=""><br class=""></div><div class=""> Otherwise, files don't link when using a GNU linker, which is more</div><div class=""> sensitive on the order of the source file relative to the various</div><div class=""> linked libraries. See <a href="http://c-faq.com/lib/libsearch.html" class="">http://c-faq.com/lib/libsearch.html</a> for an</div><div class=""> explanation of the problem.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">I'm pretty sure that's the problem. The old format didn't honor LLVM_USE_LINKER anymore than the new one does AFAICT, and if substitutions.sh.cpp was your only failing test, that's highly suspicious of the problem I fixed in 9949cfbd05a076ee. Please let me know if that helped!</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Louis</div><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 7, 2020, at 06:35, David Zarzycki <<a href="mailto:dave@znu.io" class="">dave@znu.io</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">Hi Louis,<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">I must apologize. So the problem persists and my testing was *slightly* inconsistent when I ran this on your behalf. I forgot to force the build to use the system provided clang (version 9 which uses GNU ld by default) and instead the default compiler (clang top-of-tree which uses LLVM lld by default).<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">I've done some debugging and the problem seems to twofold:<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">1) the bug is linker specific. It works with LLVM's but not GNU's ld or ld.gold.<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">2) The LLVM_USE_LINKER build option is not being honored by the libc++ "new format" change.<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">Personally, I'm trying to figure out right now if there are other CMake options that can force the libcxx test suite to use LLD when using the system compiler. That being said, I'd imagine that others will eventually run into this bug. Here is a diff of GNU ld and lld invocations by clang:<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-"/usr/bin/ld"<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+"/p/llvm/bin/ld.lld"<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--hash-style=gnu<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">---build-id<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--eh-frame-hdr<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-m<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">elf_x86_64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">@@ -8,17 +7,16 @@<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">/lib64/ld-linux-x86-64.so.2<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">/tmp/xyz/r/projects/libcxx/test/libcxx/selftest/newformat/<a href="http://sh.cpp/Output/substitutions.sh.cpp.tmp.exe" class="">sh.cpp/Output/substitutions.sh.cpp.tmp.exe</a><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-/usr/bin/../lib/gcc/x86_64-redhat-linux/9/../../../../lib64/crt1.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-/usr/bin/../lib/gcc/x86_64-redhat-linux/9/../../../../lib64/crti.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-/usr/bin/../lib/gcc/x86_64-redhat-linux/9/crtbegin.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+/usr/lib/gcc/x86_64-redhat-linux/9/../../../../lib64/crt1.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+/usr/lib/gcc/x86_64-redhat-linux/9/../../../../lib64/crti.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+/usr/lib/gcc/x86_64-redhat-linux/9/crtbegin.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-L/tmp/xyz/r/./lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--L/usr/bin/../lib/gcc/x86_64-redhat-linux/9<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--L/usr/bin/../lib/gcc/x86_64-redhat-linux/9/../../../../lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--L/usr/bin/../lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+-L/usr/lib/gcc/x86_64-redhat-linux/9<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+-L/usr/lib/gcc/x86_64-redhat-linux/9/../../../../lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+-L/p/llvm/bin/../lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-L/lib/../lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-L/usr/lib/../lib64<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--L/usr/bin/../lib/gcc/x86_64-redhat-linux/9/../../..<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">--L/usr/bin/../lib<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+-L/usr/lib/gcc/x86_64-redhat-linux/9/../../..<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-L/lib<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-L/usr/lib<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-rpath<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">@@ -34,6 +32,6 @@<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-lc<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-lgcc_s<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-lgcc<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-/tmp/substitutions-bd3c1b.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-/usr/bin/../lib/gcc/x86_64-redhat-linux/9/crtend.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">-/usr/bin/../lib/gcc/x86_64-redhat-linux/9/../../../../lib64/crtn.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+/tmp/substitutions-1e1623.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+/usr/lib/gcc/x86_64-redhat-linux/9/crtend.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">+/usr/lib/gcc/x86_64-redhat-linux/9/../../../../lib64/crtn.o<br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""></div><div style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class="">On Mon, Apr 6, 2020, at 6:08 PM, David Zarzycki via libcxx-commits wrote:<br class=""></div><blockquote type="cite" id="qt" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><div class="">This passes. Thanks!<br class=""></div><div class=""><br class=""></div><div class="">On Mon, Apr 6, 2020, at 11:28 AM, Louis Dionne wrote:<br class=""></div><blockquote type="cite" id="qt-qt" class=""><div class=""><br class=""></div><div class=""><div class=""><br class=""></div><blockquote type="cite" class="qt-qt-"><div class="qt-qt-">On Apr 5, 2020, at 06:58, David Zarzycki <<a href="mailto:dave@znu.io" class="qt-qt-">dave@znu.io</a>> wrote:<br class=""></div><div class=""><br class=""></div><div class="qt-qt-"><div class="qt-qt-"><div class="">Hi Louis,<br class=""></div><div class=""><br class=""></div><div class="">This is breaking one test on release (no assert) testing on Fedora 31 (x86-64). Since this change was intentionally done on the weekend to shake out problems, I'm going to revert this. Thanks for understanding. For context , what follows is the failure.<br class=""></div></div></div></blockquote><div class=""><br class=""></div><div class="">Thanks! This was indeed the purpose of the commit. I can't find the exact root cause of the issue you are seeing, however I just pushed fixes for a similar issue that I think is likely the same as yours. Could you try running this command with the latest master?<br class=""></div><div class=""><br class=""></div><div class=""><span class="qt-font"><span class="font" style="font-family: Monaco;"><span class="qt-qt-" style="font-style: normal;"> $ <build-dir>/bin/llvm-lit -sv libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp --param=use_new_format=True</span></span></span><br class=""></div><div class=""><br class=""></div><div class="">This should confirm that the problem has been fixed. In any case, I'll try enabling the new format by default again tonight, so we'll see if it didn't fix it.<br class=""></div><div class=""><br class=""></div><div class="">Thanks,<br class=""></div><div class="">Louis<br class=""></div><div class=""><br class=""></div><blockquote type="cite" class="qt-qt-"><div class="qt-qt-"><div class="qt-qt-"><div class=""><br class=""></div><div class="">Dave<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">FAIL: libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp (54225 of 62636)<br class=""></div><div class="">******************** TEST 'libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp' FAILED ********************<br class=""></div><div class="">Script:<br class=""></div><div class="">--<br class=""></div><div class="">: 'RUN: at line 16'; /usr/bin/clang++ -Werror=thread-safety -std=c++2a -include /home/dave/s/lp/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/dave/s/lp/libcxx/include -I/tmp/_update_lc/r/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/dave/s/lp/libcxx/test/support -ftemplate-depth=270 -L/tmp/_update_lc/r/./lib64 -Wl,-rpath,/tmp/_update_lc/r/./lib64 -nodefaultlibs -lc++experimental /tmp/_update_lc/r/./lib64/libc++.a -lc++abi -lm -lgcc_s -lgcc -lpthread -lrt -lc -lgcc_s -lgcc -o /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe /home/dave/s/lp/libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp<br class=""></div><div class="">: 'RUN: at line 17'; /usr/bin/python /home/dave/s/lp/libcxx/utils/run.py --codesign_identity "" --dependencies /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe --env -- /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe "HELLO"<br class=""></div><div class="">--<br class=""></div><div class="">Exit Code: 1<br class=""></div><div class=""><br class=""></div><div class="">Command Output (stderr):<br class=""></div><div class="">--<br class=""></div><div class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `main':<br class=""></div><div class="">substitutions.sh.cpp:(.text+0xb7): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::~basic_string()'<br class=""></div><div class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::basic_string<decltype(nullptr)>(char const*)':<br class=""></div><div class="">substitutions.sh.cpp:(.text._ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEC2IDnEEPKc[_ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEC2IDnEEPKc]+0x45): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__init(char const*, unsigned long)'<br class=""></div><div class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `bool std::__1::operator==<char, std::__1::char_traits<char>, std::__1::allocator<char> >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*)':<br class=""></div><div class="">substitutions.sh.cpp:(.text._ZNSt3__1eqIcNS_11char_traitsIcEENS_9allocatorIcEEEEbRKNS_12basic_stringIT_T0_T1_EEPKS6_[_ZNSt3__1eqIcNS_11char_traitsIcEENS_9allocatorIcEEEEbRKNS_12basic_stringIT_T0_T1_EEPKS6_]+0x5c): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::compare(unsigned long, unsigned long, char const*, unsigned long) const'<br class=""></div><div class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `__clang_call_terminate':<br class=""></div><div class="">substitutions.sh.cpp:(.text.__clang_call_terminate[__clang_call_terminate]+0x2): undefined reference to `__cxa_begin_catch'<br class=""></div><div class="">/usr/bin/ld: substitutions.sh.cpp:(.text.__clang_call_terminate[__clang_call_terminate]+0xb): undefined reference to `std::terminate()'<br class=""></div><div class="">/usr/bin/ld: /tmp/substitutions-945c39.o:(.eh_frame+0x1eb): undefined reference to `__gxx_personality_v0'<br class=""></div><div class="">clang-9: error: linker command failed with exit code 1 (use -v to see invocation)<br class=""></div><div class=""><br class=""></div><div class="">--<br class=""></div><div class=""><br class=""></div><div class="">********************<br class=""></div><div class=""><br class=""></div><div class="">Testing Time: 157.81s<br class=""></div><div class="">********************<br class=""></div><div class="">Failing Tests (1):<br class=""></div><div class=""> libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp<br class=""></div><div class=""><br class=""></div><div class=""> Expected Passes : 45136<br class=""></div><div class=""> Expected Failures : 133<br class=""></div><div class=""> Unsupported Tests : 17366<br class=""></div><div class=""> Unexpected Failures: 1<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">On Sat, Apr 4, 2020, at 4:58 PM, Louis Dionne via libcxx-commits wrote:<br class=""></div><blockquote type="cite" class="qt-qt-"><div class=""><br class=""></div><div class="">Author: Louis Dionne<br class=""></div><div class="">Date: 2020-04-04T16:57:16-04:00<br class=""></div><div class="">New Revision: 1580c76c4a08e24adc34ae0a4ff4f97969188268<br class=""></div><div class=""><br class=""></div><div class="">URL:<span class="Apple-converted-space"> </span><br class=""></div><div class=""><a href="https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268" class="qt-qt-">https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268</a><br class=""></div><div class="">DIFF:<span class="Apple-converted-space"> </span><br class=""></div><div class=""><a href="https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268.diff" class="">https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268.diff</a><br class=""></div><div class=""><br class=""></div><div class="">LOG: [libc++] Enable the new libc++ testing format by default<br class=""></div><div class=""><br class=""></div><div class="">Both test formats are equivalent, so this *should* not be a problem.<br class=""></div><div class="">However, I'm taking advantage of the week-end to test this and see if<br class=""></div><div class="">there are any failures. If so, it should be fine to revert this until<br class=""></div><div class="">the failures have been addressed.<br class=""></div><div class=""><br class=""></div><div class="">For the time being, it is still possible to use the old format by passing<br class=""></div><div class="">`--param=use_old_format=True` when running Lit.<br class=""></div><div class=""><br class=""></div><div class="">Added:<span class="Apple-converted-space"> </span><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">Modified:<span class="Apple-converted-space"> </span><br class=""></div><div class=""> libcxx/test/lit.cfg<br class=""></div><div class=""><br class=""></div><div class="">Removed:<span class="Apple-converted-space"> </span><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">################################################################################<br class=""></div><div class="">diff --git a/libcxx/test/lit.cfg b/libcxx/test/lit.cfg<br class=""></div><div class="">index 8f42dd7c468b..86e806067a5b 100644<br class=""></div><div class="">--- a/libcxx/test/lit.cfg<br class=""></div><div class="">+++ b/libcxx/test/lit.cfg<br class=""></div><div class="">@@ -52,9 +52,9 @@ config_module = __import__(config_module_name,<span class="Apple-converted-space"> </span><br class=""></div><div class="">fromlist=['Configuration'])<br class=""></div><div class="">configuration = config_module.Configuration(lit_config, config)<br class=""></div><div class="">configuration.configure()<br class=""></div><div class="">configuration.print_config_info()<br class=""></div><div class="">-if lit_config.params.get('use_new_format', False):<br class=""></div><div class="">- lit_config.note("Using the experimental libc++ testing format")<br class=""></div><div class="">+if lit_config.params.get('use_old_format', False):<br class=""></div><div class="">+ lit_config.note("Using the old libc++ testing format")<br class=""></div><div class="">+ config.test_format = configuration.get_test_format()<br class=""></div><div class="">+else:<br class=""></div><div class=""> import libcxx.test.newformat<br class=""></div><div class=""> config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()<br class=""></div><div class="">-else:<br class=""></div><div class="">- config.test_format = configuration.get_test_format()<br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">_______________________________________________<br class=""></div><div class="">libcxx-commits mailing list<br class=""></div><div class=""><a href="mailto:libcxx-commits@lists.llvm.org" class="">libcxx-commits@lists.llvm.org</a><br class=""></div><div class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br class=""></div></blockquote></div></div></blockquote></div></blockquote><div class=""><br class=""></div><div class="">_______________________________________________<br class=""></div><div class="">libcxx-commits mailing list<br class=""></div><div class=""><a href="mailto:libcxx-commits@lists.llvm.org" class="">libcxx-commits@lists.llvm.org</a><br class=""></div><div class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a></div></blockquote></div></blockquote></div><br class=""></body></html>