<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>This passes. Thanks!</div><div><br></div><div>On Mon, Apr 6, 2020, at 11:28 AM, Louis Dionne wrote:<br></div><blockquote type="cite" id="qt"><div><br></div><div><div><br></div><blockquote type="cite" class="qt-"><div class="qt-">On Apr 5, 2020, at 06:58, David Zarzycki <<a href="mailto:dave@znu.io" class="qt-">dave@znu.io</a>> wrote:<br></div><div><br></div><div class="qt-"><div class="qt-"><div>Hi Louis,<br></div><div><br></div><div>This is breaking one test on release (no assert) testing on Fedora 31 (x86-64). Since this change was intentionally done on the weekend to shake out problems, I'm going to revert this. Thanks for understanding. For context , what follows is the failure.<br></div></div></div></blockquote><div><br></div><div>Thanks! This was indeed the purpose of the commit. I can't find the exact root cause of the issue you are seeing, however I just pushed fixes for a similar issue that I think is likely the same as yours. Could you try running this command with the latest master?<br></div><div><br></div><div><span class="font" style="font-family:Monaco;"><span style="font-style:normal;" class="qt-"> $ <build-dir>/bin/llvm-lit -sv libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp --param=use_new_format=True</span></span><br></div><div><br></div><div>This should confirm that the problem has been fixed. In any case, I'll try enabling the new format by default again tonight, so we'll see if it didn't fix it.<br></div><div><br></div><div>Thanks,<br></div><div>Louis<br></div><div><br></div><blockquote type="cite" class="qt-"><div class="qt-"><div class="qt-"><div><br></div><div>Dave<br></div><div><br></div><div><br></div><div><br></div><div>FAIL: libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp (54225 of 62636)<br></div><div>******************** TEST 'libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp' FAILED ********************<br></div><div>Script:<br></div><div>--<br></div><div>: 'RUN: at line 16'; /usr/bin/clang++ -Werror=thread-safety -std=c++2a -include /home/dave/s/lp/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/dave/s/lp/libcxx/include -I/tmp/_update_lc/r/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/dave/s/lp/libcxx/test/support -ftemplate-depth=270 -L/tmp/_update_lc/r/./lib64 -Wl,-rpath,/tmp/_update_lc/r/./lib64 -nodefaultlibs -lc++experimental /tmp/_update_lc/r/./lib64/libc++.a -lc++abi -lm -lgcc_s -lgcc -lpthread -lrt -lc -lgcc_s -lgcc -o /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe /home/dave/s/lp/libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp<br></div><div>: 'RUN: at line 17'; /usr/bin/python /home/dave/s/lp/libcxx/utils/run.py --codesign_identity "" --dependencies /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe --env -- /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe "HELLO"<br></div><div>--<br></div><div>Exit Code: 1<br></div><div><br></div><div>Command Output (stderr):<br></div><div>--<br></div><div>/usr/bin/ld: /tmp/substitutions-945c39.o: in function `main':<br></div><div>substitutions.sh.cpp:(.text+0xb7): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::~basic_string()'<br></div><div>/usr/bin/ld: /tmp/substitutions-945c39.o: in function `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::basic_string<decltype(nullptr)>(char const*)':<br></div><div>substitutions.sh.cpp:(.text._ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEC2IDnEEPKc[_ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEC2IDnEEPKc]+0x45): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__init(char const*, unsigned long)'<br></div><div>/usr/bin/ld: /tmp/substitutions-945c39.o: in function `bool std::__1::operator==<char, std::__1::char_traits<char>, std::__1::allocator<char> >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*)':<br></div><div>substitutions.sh.cpp:(.text._ZNSt3__1eqIcNS_11char_traitsIcEENS_9allocatorIcEEEEbRKNS_12basic_stringIT_T0_T1_EEPKS6_[_ZNSt3__1eqIcNS_11char_traitsIcEENS_9allocatorIcEEEEbRKNS_12basic_stringIT_T0_T1_EEPKS6_]+0x5c): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::compare(unsigned long, unsigned long, char const*, unsigned long) const'<br></div><div>/usr/bin/ld: /tmp/substitutions-945c39.o: in function `__clang_call_terminate':<br></div><div>substitutions.sh.cpp:(.text.__clang_call_terminate[__clang_call_terminate]+0x2): undefined reference to `__cxa_begin_catch'<br></div><div>/usr/bin/ld: substitutions.sh.cpp:(.text.__clang_call_terminate[__clang_call_terminate]+0xb): undefined reference to `std::terminate()'<br></div><div>/usr/bin/ld: /tmp/substitutions-945c39.o:(.eh_frame+0x1eb): undefined reference to `__gxx_personality_v0'<br></div><div>clang-9: error: linker command failed with exit code 1 (use -v to see invocation)<br></div><div><br></div><div>--<br></div><div><br></div><div>********************<br></div><div><br></div><div>Testing Time: 157.81s<br></div><div>********************<br></div><div>Failing Tests (1):<br></div><div> libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp<br></div><div><br></div><div> Expected Passes : 45136<br></div><div> Expected Failures : 133<br></div><div> Unsupported Tests : 17366<br></div><div> Unexpected Failures: 1<br></div><div><br></div><div><br></div><div><br></div><div>On Sat, Apr 4, 2020, at 4:58 PM, Louis Dionne via libcxx-commits wrote:<br></div><blockquote type="cite" class="qt-"><div><br></div><div>Author: Louis Dionne<br></div><div>Date: 2020-04-04T16:57:16-04:00<br></div><div>New Revision: 1580c76c4a08e24adc34ae0a4ff4f97969188268<br></div><div><br></div><div>URL: <br></div><div><a href="https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268" class="qt-">https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268</a><br></div><div>DIFF: <br></div><div>https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268.diff<br></div><div><br></div><div>LOG: [libc++] Enable the new libc++ testing format by default<br></div><div><br></div><div>Both test formats are equivalent, so this *should* not be a problem.<br></div><div>However, I'm taking advantage of the week-end to test this and see if<br></div><div>there are any failures. If so, it should be fine to revert this until<br></div><div>the failures have been addressed.<br></div><div><br></div><div>For the time being, it is still possible to use the old format by passing<br></div><div>`--param=use_old_format=True` when running Lit.<br></div><div><br></div><div>Added: <br></div><div><br></div><div><br></div><div>Modified: <br></div><div> libcxx/test/lit.cfg<br></div><div><br></div><div>Removed: <br></div><div><br></div><div><br></div><div><br></div><div>################################################################################<br></div><div>diff --git a/libcxx/test/lit.cfg b/libcxx/test/lit.cfg<br></div><div>index 8f42dd7c468b..86e806067a5b 100644<br></div><div>--- a/libcxx/test/lit.cfg<br></div><div>+++ b/libcxx/test/lit.cfg<br></div><div>@@ -52,9 +52,9 @@ config_module = __import__(config_module_name, <br></div><div>fromlist=['Configuration'])<br></div><div> configuration = config_module.Configuration(lit_config, config)<br></div><div> configuration.configure()<br></div><div> configuration.print_config_info()<br></div><div>-if lit_config.params.get('use_new_format', False):<br></div><div>- lit_config.note("Using the experimental libc++ testing format")<br></div><div>+if lit_config.params.get('use_old_format', False):<br></div><div>+ lit_config.note("Using the old libc++ testing format")<br></div><div>+ config.test_format = configuration.get_test_format()<br></div><div>+else:<br></div><div> import libcxx.test.newformat<br></div><div> config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()<br></div><div>-else:<br></div><div>- config.test_format = configuration.get_test_format()<br></div><div><br></div><div><br></div><div><br></div><div>_______________________________________________<br></div><div>libcxx-commits mailing list<br></div><div>libcxx-commits@lists.llvm.org<br></div><div>https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits<br></div></blockquote></div></div></blockquote></div></blockquote><div><br></div></body></html>