<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 5, 2020, at 06:58, David Zarzycki <<a href="mailto:dave@znu.io" class="">dave@znu.io</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Hi Louis,<br class=""><br class="">This is breaking one test on release (no assert) testing on Fedora 31 (x86-64). Since this change was intentionally done on the weekend to shake out problems, I'm going to revert this. Thanks for understanding. For context , what follows is the failure.<br class=""></div></div></blockquote><div><br class=""></div><div>Thanks! This was indeed the purpose of the commit. I can't find the exact root cause of the issue you are seeing, however I just pushed fixes for a similar issue that I think is likely the same as yours. Could you try running this command with the latest master?</div><div><br class=""></div><div><font face="Monaco" class=""><span style="font-style: normal;" class=""> $ <build-dir>/bin/llvm-lit -sv libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp --param=use_new_format=True</span></font></div><div><br class=""></div><div>This should confirm that the problem has been fixed. In any case, I'll try enabling the new format by default again tonight, so we'll see if it didn't fix it.</div><div><br class=""></div><div>Thanks,</div><div>Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><br class="">Dave<br class=""><br class=""><br class=""><br class="">FAIL: libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp (54225 of 62636)<br class="">******************** TEST 'libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp' FAILED ********************<br class="">Script:<br class="">--<br class="">: 'RUN: at line 16'; /usr/bin/clang++ -Werror=thread-safety -std=c++2a -include /home/dave/s/lp/libcxx/test/support/nasty_macros.h -nostdinc++ -I/home/dave/s/lp/libcxx/include -I/tmp/_update_lc/r/projects/libcxx/include/c++build -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -I/home/dave/s/lp/libcxx/test/support -ftemplate-depth=270 -L/tmp/_update_lc/r/./lib64 -Wl,-rpath,/tmp/_update_lc/r/./lib64 -nodefaultlibs -lc++experimental /tmp/_update_lc/r/./lib64/libc++.a -lc++abi -lm -lgcc_s -lgcc -lpthread -lrt -lc -lgcc_s -lgcc -o /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe /home/dave/s/lp/libcxx/test/libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp<br class="">: 'RUN: at line 17'; /usr/bin/python /home/dave/s/lp/libcxx/utils/run.py --codesign_identity "" --dependencies /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe --env -- /tmp/_update_lc/r/projects/libcxx/test/libcxx/selftest/newformat/sh.cpp/Output/substitutions.sh.cpp.tmp.exe "HELLO"<br class="">--<br class="">Exit Code: 1<br class=""><br class="">Command Output (stderr):<br class="">--<br class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `main':<br class="">substitutions.sh.cpp:(.text+0xb7): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::~basic_string()'<br class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::basic_string<decltype(nullptr)>(char const*)':<br class="">substitutions.sh.cpp:(.text._ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEC2IDnEEPKc[_ZNSt3__112basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEC2IDnEEPKc]+0x45): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::__init(char const*, unsigned long)'<br class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `bool std::__1::operator==<char, std::__1::char_traits<char>, std::__1::allocator<char> >(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*)':<br class="">substitutions.sh.cpp:(.text._ZNSt3__1eqIcNS_11char_traitsIcEENS_9allocatorIcEEEEbRKNS_12basic_stringIT_T0_T1_EEPKS6_[_ZNSt3__1eqIcNS_11char_traitsIcEENS_9allocatorIcEEEEbRKNS_12basic_stringIT_T0_T1_EEPKS6_]+0x5c): undefined reference to `std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::compare(unsigned long, unsigned long, char const*, unsigned long) const'<br class="">/usr/bin/ld: /tmp/substitutions-945c39.o: in function `__clang_call_terminate':<br class="">substitutions.sh.cpp:(.text.__clang_call_terminate[__clang_call_terminate]+0x2): undefined reference to `__cxa_begin_catch'<br class="">/usr/bin/ld: substitutions.sh.cpp:(.text.__clang_call_terminate[__clang_call_terminate]+0xb): undefined reference to `std::terminate()'<br class="">/usr/bin/ld: /tmp/substitutions-945c39.o:(.eh_frame+0x1eb): undefined reference to `__gxx_personality_v0'<br class="">clang-9: error: linker command failed with exit code 1 (use -v to see invocation)<br class=""><br class="">--<br class=""><br class="">********************<br class=""><br class="">Testing Time: 157.81s<br class="">********************<br class="">Failing Tests (1):<br class=""> libc++ :: libcxx/selftest/newformat/sh.cpp/substitutions.sh.cpp<br class=""><br class=""> Expected Passes : 45136<br class=""> Expected Failures : 133<br class=""> Unsupported Tests : 17366<br class=""> Unexpected Failures: 1<br class=""><br class=""><br class=""><br class="">On Sat, Apr 4, 2020, at 4:58 PM, Louis Dionne via libcxx-commits wrote:<br class=""><blockquote type="cite" class=""><br class="">Author: Louis Dionne<br class="">Date: 2020-04-04T16:57:16-04:00<br class="">New Revision: 1580c76c4a08e24adc34ae0a4ff4f97969188268<br class=""><br class="">URL: <br class=""><a href="https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268" class="">https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268</a><br class="">DIFF: <br class="">https://github.com/llvm/llvm-project/commit/1580c76c4a08e24adc34ae0a4ff4f97969188268.diff<br class=""><br class="">LOG: [libc++] Enable the new libc++ testing format by default<br class=""><br class="">Both test formats are equivalent, so this *should* not be a problem.<br class="">However, I'm taking advantage of the week-end to test this and see if<br class="">there are any failures. If so, it should be fine to revert this until<br class="">the failures have been addressed.<br class=""><br class="">For the time being, it is still possible to use the old format by passing<br class="">`--param=use_old_format=True` when running Lit.<br class=""><br class="">Added: <br class=""><br class=""><br class="">Modified: <br class=""> libcxx/test/lit.cfg<br class=""><br class="">Removed: <br class=""><br class=""><br class=""><br class="">################################################################################<br class="">diff --git a/libcxx/test/lit.cfg b/libcxx/test/lit.cfg<br class="">index 8f42dd7c468b..86e806067a5b 100644<br class="">--- a/libcxx/test/lit.cfg<br class="">+++ b/libcxx/test/lit.cfg<br class="">@@ -52,9 +52,9 @@ config_module = __import__(config_module_name, <br class="">fromlist=['Configuration'])<br class=""> configuration = config_module.Configuration(lit_config, config)<br class=""> configuration.configure()<br class=""> configuration.print_config_info()<br class="">-if lit_config.params.get('use_new_format', False):<br class="">- lit_config.note("Using the experimental libc++ testing format")<br class="">+if lit_config.params.get('use_old_format', False):<br class="">+ lit_config.note("Using the old libc++ testing format")<br class="">+ config.test_format = configuration.get_test_format()<br class="">+else:<br class=""> import libcxx.test.newformat<br class=""> config.test_format = libcxx.test.newformat.CxxStandardLibraryTest()<br class="">-else:<br class="">- config.test_format = configuration.get_test_format()<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">libcxx-commits mailing list<br class="">libcxx-commits@lists.llvm.org<br class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits<br class=""><br class=""></blockquote></div></div></blockquote></div><br class=""></body></html>