<div dir="ltr">In fact this change wasn't picked up until 4 builds after things started breaking.<div><a href="http://lab.llvm.org:8014/builders/netbsd-amd64/builds/838">http://lab.llvm.org:8014/builders/netbsd-amd64/builds/838</a>  <br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 20, 2020 at 4:31 AM Eric Fiselier <<a href="mailto:eric@efcs.ca">eric@efcs.ca</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I don't see why you think the given error maps to this change.<div><br></div><div>This change isn't in the set of changes in the build you point to:<br><a href="http://lab.llvm.org:8014/builders/netbsd-amd64/builds/834/" target="_blank">http://lab.llvm.org:8014/builders/netbsd-amd64/builds/834/</a> <br><br>And the build before it doesn't fail.<br><a href="http://lab.llvm.org:8014/builders/netbsd-amd64/builds/833/" target="_blank">http://lab.llvm.org:8014/builders/netbsd-amd64/builds/833/</a> </div><div><br></div><div>Can you elucidate why this change is responsible?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 20, 2020 at 3:53 AM Michał Górny via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">mgorny added a comment.<br>
<br>
I'm afraid this breaks stuff. TableGen built against libc++ after this change misbehaves:<br>
<br>
  [18/31] Building ARMGenSystemRegister.inc...<br>
  FAILED: lib/Target/ARM/ARMGenSystemRegister.inc <br>
  cd /home/motus/netbsd8/netbsd8/build-stage2 && /home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen -gen-searchable-tables -I /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM -I /home/motus/netbsd8/netbsd8/llvm-project/llvm/include -I /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM/ARM.td --write-if-changed -o lib/Target/ARM/ARMGenSystemRegister.inc -d lib/Target/ARM/ARMGenSystemRegister.inc.d<br>
  /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM/ARM.td:1269:1: error: Reached EOF without matching #endif<br>
<br>
  ^<br>
  #0 0x000000000049b032 llvm::sys::PrintStackTrace(llvm::raw_ostream&) (/home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen+0x49b032)<br>
  #1 0x000000000049905c llvm::sys::RunSignalHandlers() (/home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen+0x49905c)<br>
  #2 0x000000000049b5e0 SignalHandler(int) (/home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen+0x49b5e0)<br>
  Stack dump:<br>
  0.      Program arguments: /home/motus/netbsd8/netbsd8/build-stage2/bin/llvm-tblgen -gen-searchable-tables -I /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM -I /home/motus/netbsd8/netbsd8/llvm-project/llvm/include -I /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target /home/motus/netbsd8/netbsd8/llvm-project/llvm/lib/Target/ARM/ARM.td --write-if-changed -o lib/Target/ARM/ARMGenSystemRegister.inc -d lib/Target/ARM/ARMGenSystemRegister.inc.d <br>
  ninja: build stopped: subcommand failed.<br>
<br>
<a href="http://lab.llvm.org:8014/builders/netbsd-amd64/builds/834/steps/ninja%20build%20local/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8014/builders/netbsd-amd64/builds/834/steps/ninja%20build%20local/logs/stdio</a><br>
<br>
<br>
Repository:<br>
  rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D72160/new/" rel="noreferrer" target="_blank">https://reviews.llvm.org/D72160/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D72160" rel="noreferrer" target="_blank">https://reviews.llvm.org/D72160</a><br>
<br>
<br>
<br>
</blockquote></div>
</blockquote></div>