<div dir="ltr">Sorry about the breakage Martin. I'll commit a speculative fix shortly.<div><br></div><div>There are currently no real Windows buildbots for libc++. I was attempting to</div><div>use Appveyor (<a href="https://ci.appveyor.com/project/llvm-mirror/libcxx">https://ci.appveyor.com/project/llvm-mirror/libcxx</a>), but that's</div><div>been unmaintained and red for a long time now.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 16, 2020 at 3:40 AM Martin Storsjö <<a href="mailto:martin@martin.st">martin@martin.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, 15 Jan 2020, Eric Fiselier via libcxx-commits wrote:<br>
<br>
><br>
> Author: Eric Fiselier<br>
> Date: 2020-01-15T17:02:17-05:00<br>
> New Revision: 2d8f23f571635c1fb983b40c4c2548716a5b65b6<br>
><br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/2d8f23f571635c1fb983b40c4c2548716a5b65b6" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/2d8f23f571635c1fb983b40c4c2548716a5b65b6</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/2d8f23f571635c1fb983b40c4c2548716a5b65b6.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/2d8f23f571635c1fb983b40c4c2548716a5b65b6.diff</a><br>
><br>
> LOG: [libc++] Explicitly mark basic_string<...>::npos with default<br>
> visibility.<br>
<br>
This breaks shared builds for windows (both with clang-cl and in mingw <br>
mode):<br>
<br>
In file included from ..\src\thread.cpp:12:<br>
In file included from ..\include\thread:92:<br>
In file included from ..\include\system_error:149:<br>
..\include\string(4241,59): error: redeclaration of 'std::__1::basic_string::npos' cannot add 'dllexport' attribute<br>
                basic_string<_CharT, _Traits, _Allocator>::npos;<br>
                                                           ^<br>
..\include\string(788,28): note: previous declaration is here<br>
     static const size_type npos = -1;<br>
                            ^<br>
<br>
(Relatedly, is there any buildbot set up for libcxx on windows?)<br>
<br>
// Martin<br>
<br>
</blockquote></div>