<div dir="ltr">I'll take a look at D69505 shortly.<div><br></div><div>Can you confirm that adding _LIBCPP_FUNC_VIS to the initial in-class declaration for npos fixes the Windows build?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jan 16, 2020 at 10:42 AM Martin Storsjö <<a href="mailto:martin@martin.st">martin@martin.st</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ok,<br>
<br>
And thanks for confirming re buildbots; I was a bit surprised to see the <br>
amount of failing tests in libc++ on windows when I finally got a setup to <br>
run them (regarding <a href="https://reviews.llvm.org/D69505" rel="noreferrer" target="_blank">https://reviews.llvm.org/D69505</a>, where I'd like an ack <br>
from you or someone else of the libcxx maintainers before proceeding, in <br>
addition to Reid's approval).<br>
<br>
// Martin<br>
<br>
On Thu, 16 Jan 2020, Eric Fiselier wrote:<br>
<br>
> Sorry about the breakage Martin. I'll commit a speculative<br>
> fix shortly.<br>
> There are currently no real Windows buildbots for libc++. I<br>
> was attempting to<br>
> use Appveyor<br>
> (<a href="https://ci.appveyor.com/project/llvm-mirror/libcxx" rel="noreferrer" target="_blank">https://ci.appveyor.com/project/llvm-mirror/libcxx</a>), but<br>
> that's<br>
> been unmaintained and red for a long time now.<br>
> <br>
> On Thu, Jan 16, 2020 at 3:40 AM Martin Storsjö<br>
> <<a href="mailto:martin@martin.st" target="_blank">martin@martin.st</a>> wrote:<br>
>       On Wed, 15 Jan 2020, Eric Fiselier via<br>
>       libcxx-commits wrote:<br>
><br>
>       ><br>
>       > Author: Eric Fiselier<br>
>       > Date: 2020-01-15T17:02:17-05:00<br>
>       > New Revision:<br>
>       2d8f23f571635c1fb983b40c4c2548716a5b65b6<br>
>       ><br>
>       > URL:<a href="https://github.com/llvm/llvm-project/commit/2d8f23f571635c1f" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/2d8f23f571635c1f</a><br>
>       b983b40c4c2548716a5b65b6<br>
>       > DIFF:<a href="https://github.com/llvm/llvm-project/commit/2d8f23f571635c1f" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/2d8f23f571635c1f</a><br>
>       b983b40c4c2548716a5b65b6.diff<br>
>       ><br>
>       > LOG: [libc++] Explicitly mark<br>
>       basic_string<...>::npos with default<br>
>       > visibility.<br>
><br>
>       This breaks shared builds for windows (both with<br>
>       clang-cl and in mingw<br>
>       mode):<br>
><br>
>       In file included from ..\src\thread.cpp:12:<br>
>       In file included from ..\include\thread:92:<br>
>       In file included from<br>
>       ..\include\system_error:149:<br>
>       ..\include\string(4241,59): error: redeclaration<br>
>       of 'std::__1::basic_string::npos' cannot add<br>
>       'dllexport' attribute<br>
>                       basic_string<_CharT, _Traits,<br>
>       _Allocator>::npos;<br>
>                                                        <br>
>                ^<br>
>       ..\include\string(788,28): note: previous<br>
>       declaration is here<br>
>            static const size_type npos = -1;<br>
>                                   ^<br>
><br>
>       (Relatedly, is there any buildbot set up for<br>
>       libcxx on windows?)<br>
><br>
>       // Martin<br>
> <br>
> <br>
></blockquote></div>