<div dir="ltr"><a href="https://reviews.llvm.org/D68477">https://reviews.llvm.org/D68477</a> turns testing of this option off by default.<br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 4, 2019 at 2:23 AM David Zarzycki <<a href="mailto:dave@znu.io">dave@znu.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="overflow-wrap: break-word;">As of r373716, it’s still failing:<div><br></div><div><a href="https://gist.github.com/davezarzycki/6722c3b361d7744b2079e8ec5ee28516" target="_blank">https://gist.github.com/davezarzycki/6722c3b361d7744b2079e8ec5ee28516</a></div><div><br></div><div><br><div><br><blockquote type="cite"><div>On Oct 4, 2019, at 8:56 AM, Fāng-ruì Sòng <<a href="mailto:maskray@google.com" target="_blank">maskray@google.com</a>> wrote:</div><br><div><div dir="ltr">If Python 3 still doesn't work or it breaks for some platforms using gdb linked against libpython2*, I think we probably should just disable or delete test/pretty_printers/gdb_pretty_printer_test.py and wait for Sterling to fix it. This will be less disruptive than reverting D65238/r371131.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 4, 2019 at 1:53 PM Fāng-ruì Sòng <<a href="mailto:maskray@google.com" target="_blank">maskray@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>r373452 was an attempt to fix gdb linked against libpython3*.so. The Python 3 pretty printer never worked.</div><div><br></div><div>Can you try r373691?</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 4, 2019 at 11:58 AM David Zarzycki <<a href="mailto:dave@znu.io" target="_blank">dave@znu.io</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>This still isn’t working on Fedora 31 (x86_64):<div><br></div><div><a href="https://gist.github.com/davezarzycki/1e2d91792df37c0c0295fda3414519fa" target="_blank">https://gist.github.com/davezarzycki/1e2d91792df37c0c0295fda3414519fa</a></div><div><br></div><div>Everything was fine before r373452. Can we please revert r373452?</div><div><div><br><blockquote type="cite"><div>On Oct 3, 2019, at 11:02 AM, David Zarzycki via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a>> wrote:</div><br><div><div>Still doesn’t work. Maybe we should revert r373452<br><br><blockquote type="cite">On Oct 3, 2019, at 9:19 AM, Fangrui Song via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a>> wrote:<br><br>Author: maskray<br>Date: Wed Oct  2 23:19:50 2019<br>New Revision: 373570<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=373570&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=373570&view=rev</a><br>Log:<br>Fix libc++ pretty printer test for Python 3 after D67238 (take 2)<br><br>In both Python 2 and Python 3, gdb.Value.string returns a 'str'. We just<br>need to delete a `encode("utf-8")` which would return a 'bytes' in<br>Python 3.<br><br>Modified:<br>   libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py<br><br>Modified: libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py<br>URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py?rev=373570&r1=373569&r2=373570&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py?rev=373570&r1=373569&r2=373570&view=diff</a><br>==============================================================================<br>--- libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py (original)<br>+++ libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py Wed Oct  2 23:19:50 2019<br>@@ -46,12 +46,10 @@ class CheckResult(gdb.Command):<br>            gdb.newest_frame().select()<br><br>            expectation_val = compare_frame.read_var("expectation")<br>+            check_literal = expectation_val.string(encoding="utf-8")<br>            if "PrettyPrintToRegex" in <a href="http://compare_frame.name/" target="_blank">compare_frame.name</a>():<br>-                check_literal = expectation_val.string()<br>                test_fails = not re.match(check_literal, value)<br>            else:<br>-                check_literal_string = expectation_val.string(encoding="utf-8")<br>-                check_literal = str(check_literal_string.encode("utf-8"))<br>                test_fails = value != check_literal<br><br>            if test_fails:<br><br><br>_______________________________________________<br>libcxx-commits mailing list<br><a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br></blockquote><br>_______________________________________________<br>libcxx-commits mailing list<br><a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br></div></div></blockquote></div><br></div></div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr">宋方睿</div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr"><div dir="ltr">宋方睿</div></div>
</div></blockquote></div><br></div></div></blockquote></div>