<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">As of r373716, it’s still failing:<div class=""><br class=""></div><div class=""><a href="https://gist.github.com/davezarzycki/6722c3b361d7744b2079e8ec5ee28516" class="">https://gist.github.com/davezarzycki/6722c3b361d7744b2079e8ec5ee28516</a></div><div class=""><br class=""></div><div class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 4, 2019, at 8:56 AM, Fāng-ruì Sòng <<a href="mailto:maskray@google.com" class="">maskray@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">If Python 3 still doesn't work or it breaks for some platforms using gdb linked against libpython2*, I think we probably should just disable or delete test/pretty_printers/gdb_pretty_printer_test.py and wait for Sterling to fix it. This will be less disruptive than reverting D65238/r371131.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 4, 2019 at 1:53 PM Fāng-ruì Sòng <<a href="mailto:maskray@google.com" class="">maskray@google.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr" class=""><div class="">r373452 was an attempt to fix gdb linked against libpython3*.so. The Python 3 pretty printer never worked.</div><div class=""><br class=""></div><div class="">Can you try r373691?</div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Oct 4, 2019 at 11:58 AM David Zarzycki <<a href="mailto:dave@znu.io" target="_blank" class="">dave@znu.io</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">This still isn’t working on Fedora 31 (x86_64):<div class=""><br class=""></div><div class=""><a href="https://gist.github.com/davezarzycki/1e2d91792df37c0c0295fda3414519fa" target="_blank" class="">https://gist.github.com/davezarzycki/1e2d91792df37c0c0295fda3414519fa</a></div><div class=""><br class=""></div><div class="">Everything was fine before r373452. Can we please revert r373452?</div><div class=""><div class=""><br class=""><blockquote type="cite" class=""><div class="">On Oct 3, 2019, at 11:02 AM, David Zarzycki via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank" class="">libcxx-commits@lists.llvm.org</a>> wrote:</div><br class=""><div class=""><div class="">Still doesn’t work. Maybe we should revert r373452<br class=""><br class=""><blockquote type="cite" class="">On Oct 3, 2019, at 9:19 AM, Fangrui Song via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank" class="">libcxx-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">Author: maskray<br class="">Date: Wed Oct 2 23:19:50 2019<br class="">New Revision: 373570<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=373570&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=373570&view=rev</a><br class="">Log:<br class="">Fix libc++ pretty printer test for Python 3 after D67238 (take 2)<br class=""><br class="">In both Python 2 and Python 3, gdb.Value.string returns a 'str'. We just<br class="">need to delete a `encode("utf-8")` which would return a 'bytes' in<br class="">Python 3.<br class=""><br class="">Modified:<br class=""> libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py<br class=""><br class="">Modified: libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py?rev=373570&r1=373569&r2=373570&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py?rev=373570&r1=373569&r2=373570&view=diff</a><br class="">==============================================================================<br class="">--- libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py (original)<br class="">+++ libcxx/trunk/test/pretty_printers/gdb_pretty_printer_test.py Wed Oct 2 23:19:50 2019<br class="">@@ -46,12 +46,10 @@ class CheckResult(gdb.Command):<br class=""> gdb.newest_frame().select()<br class=""><br class=""> expectation_val = compare_frame.read_var("expectation")<br class="">+ check_literal = expectation_val.string(encoding="utf-8")<br class=""> if "PrettyPrintToRegex" in <a href="http://compare_frame.name/" target="_blank" class="">compare_frame.name</a>():<br class="">- check_literal = expectation_val.string()<br class=""> test_fails = not re.match(check_literal, value)<br class=""> else:<br class="">- check_literal_string = expectation_val.string(encoding="utf-8")<br class="">- check_literal = str(check_literal_string.encode("utf-8"))<br class=""> test_fails = value != check_literal<br class=""><br class=""> if test_fails:<br class=""><br class=""><br class="">_______________________________________________<br class="">libcxx-commits mailing list<br class=""><a href="mailto:libcxx-commits@lists.llvm.org" target="_blank" class="">libcxx-commits@lists.llvm.org</a><br class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br class=""></blockquote><br class="">_______________________________________________<br class="">libcxx-commits mailing list<br class=""><a href="mailto:libcxx-commits@lists.llvm.org" target="_blank" class="">libcxx-commits@lists.llvm.org</a><br class=""><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" target="_blank" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br class=""></div></div></blockquote></div><br class=""></div></div></blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class=""><div dir="ltr" class="">宋方睿</div></div>
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature"><div dir="ltr" class="">宋方睿</div></div>
</div></blockquote></div><br class=""></div></body></html>