<div dir="ltr"><div>If I understand this correctly, the headers now require CMake build and configuration steps before</div><div>they've valid?</div><div><br></div><div>Code should be valid at rest -- without any intervention, configuration, setup, or build steps.</div><div> </div><div>/Eric<br></div><div><br></div><div><br></div><div><br></div><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Aug 8, 2019 at 8:42 AM Louis Dionne via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org">libcxx-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: ldionne<br>
Date: Thu Aug  8 05:43:13 2019<br>
New Revision: 368285<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=368285&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=368285&view=rev</a><br>
Log:<br>
[pstl] Error out when the backend is left unspecified<br>
<br>
Instead of silently falling back to the serial backend, it's better if<br>
we fail loudly when the parallel backend is left unspecified. Since we<br>
have a __pstl_config_site header, a backend should always be specified.<br>
<br>
Modified:<br>
    pstl/trunk/include/pstl/internal/pstl_config.h<br>
<br>
Modified: pstl/trunk/include/pstl/internal/pstl_config.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/pstl/trunk/include/pstl/internal/pstl_config.h?rev=368285&r1=368284&r2=368285&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/pstl/trunk/include/pstl/internal/pstl_config.h?rev=368285&r1=368284&r2=368285&view=diff</a><br>
==============================================================================<br>
--- pstl/trunk/include/pstl/internal/pstl_config.h (original)<br>
+++ pstl/trunk/include/pstl/internal/pstl_config.h Thu Aug  8 05:43:13 2019<br>
@@ -19,9 +19,7 @@<br>
 #define _PSTL_VERSION_PATCH (_PSTL_VERSION % 10)<br>
<br>
 #if !defined(_PSTL_PAR_BACKEND_SERIAL) && !defined(_PSTL_PAR_BACKEND_TBB)<br>
-// TODO: In the future, we need to handle this setting using a configure-time<br>
-//       option and something like a __config_site header.<br>
-#    define _PSTL_PAR_BACKEND_SERIAL<br>
+#    error "A parallel backend must be specified"<br>
 #endif<br>
<br>
 // Check the user-defined macro for warnings<br>
<br>
<br>
_______________________________________________<br>
libcxx-commits mailing list<br>
<a href="mailto:libcxx-commits@lists.llvm.org" target="_blank">libcxx-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-commits</a><br>
</blockquote></div></div>