<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Mar 20, 2019 at 8:05 PM Billy Robert O'Neal III via libcxx-commits <<a href="mailto:libcxx-commits@lists.llvm.org">libcxx-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: bion<br>
Date: Wed Mar 20 16:58:46 2019<br>
New Revision: 356632<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=356632&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=356632&view=rev</a><br>
Log:<br>
[libcxx] [test] Add (void) casts to operator new calls, to suppress warnings generated by [[nodiscard]].<br>
<br>
This allows these tests to pass when compiled by MSVC++.<br>
<br>
Modified:<br>
    libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp<br>
    libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align.sh.cpp<br>
    libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_align_nothrow.sh.cpp<br>
    libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size_nothrow.sh.cpp<br>
    libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align.sh.cpp<br>
    libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.single/new_size_align_nothrow.sh.cpp<br>
<br>
Modified: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp?rev=356632&r1=356631&r2=356632&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp?rev=356632&r1=356631&r2=356632&view=diff</a><br>
==============================================================================<br>
--- libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp (original)<br>
+++ libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.sh.cpp Wed Mar 20 16:58:46 2019<br>
@@ -21,7 +21,7 @@<br>
<br>
 int main(int, char**)<br>
 {<br>
-    ::operator new[](4);  // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}}<br>
+    (void)::operator new[](4);<br></blockquote><div><br></div><div>This is not an improvement.</div><div>Now these tests will pass whether or not the operator new has the 'nodiscard' attribute.<br></div><div>That was the point of this test.</div><div><br></div><div>-- Marshall</div></div></div>