[libcxx-commits] [PATCH] D88421: Add a regression test for erasing from a vector

Michael Schellenberger Costa via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 28 12:43:22 PDT 2020


miscco added a comment.

@Quuxplusone I am totally fine with you adding the basic test.

That said, it is a "general" test that does not depend whether a variable is relocatable.

The long term solution would be to define an archetype that is relocatable (Can we actually do that, I havent looked at the paper to be honest) and test with that. However, that would indeed be a quite significant amount of work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88421/new/

https://reviews.llvm.org/D88421



More information about the libcxx-commits mailing list