[libcxx-commits] [PATCH] D88421: Add a regression test for erasing from a vector

Michael Schellenberger Costa via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 28 11:00:04 PDT 2020


miscco added a comment.

I mean I do not really want to bother you, but the "correct" thing to do would be to actually not use int but one of the defined arche types (in this case one of those that count how many times they have been moved from.)

This would ensure that we indeed do not move from those elements before it and only move from those elements after it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88421/new/

https://reviews.llvm.org/D88421



More information about the libcxx-commits mailing list