[libcxx-commits] [PATCH] D88188: [libc++] Use runtime rather then compile-time glibc version check

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I think the correct way of handling this would be to define a Lit feature that expresses the fact that we're running on a newer system but we compiled on an older system. Like the reverse of what we do for back-deployment on macOS. I know this isn't what we did in D56702 <https://reviews.llvm.org/D56702>, but that strikes me as the wrong approach. It seems to me like this is something we want to tackle at the test driver level, not inside the test per-se. Am I missing something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88188/new/

https://reviews.llvm.org/D88188