[libcxx-commits] [PATCH] D87940: [SystemZ][ZOS] Porting the time functions within libc++ to z/OS

[Zbigniew Sarbinowski via Phabricator via libcxx-commits]

zibi added a comment.

There are multiple Pre-merge checks warnings coming from clang-tidy. Half of them are for existing function **posix_utimes**  and another half for new function **make_timeval** as follows:

1. defining function in the header
2. invalid case for function
3. invalid case for parameter

I intend to ignore them otherwise, the style of the file will be mixed and hard to read. Perhaps this file should be excluded from tidy checks.

There is also the following build failure not related to this patch which I'm not sure how to report it to eventually fix it.  It looks like it has been happening for couple months now.

  error: ld.lld: error: unable to find library -lcxxabi_shared




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87940/new/

https://reviews.llvm.org/D87940