[libcxx-commits] [PATCH] D86540: [libcxxabi, libunwind] support running tests in standalone mode

Mon Sep 21 08:15:44 PDT 2020

ldionne added a comment.

The approach looks good, with comments.

================
Comment at: libcxx/cmake/Modules/HandleOutOfTreeLLVM.cmake:29
+
+# In a standalone build, we don't have llvm to automatically generate the
+# llvm-lit script for us.  So we need to provide an explicit directory that
----------------
I think it might be better to instead provide the `LLVM_LIT_OUTPUT_DIR` as a "parameter" of this module. Basically, set it before including it in various projects. WDYT?

================
Comment at: libunwind/CMakeLists.txt:27
+  # Add the CMake module path of libcxx so we can reuse HandleOutOfTreeLLVM.cmake
+  set(LIBCXX_PATH ${CMAKE_CURRENT_SOURCE_DIR}/../libcxx)
+  set(LIBCXX_CMAKE_PATH "${LIBCXX_PATH}/cmake/Modules")
----------------
There's already a `LIBUNWIND_LIBCXX_PATH` defined somewhere in libunwind -- I think we should merge the two variables into one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86540/new/

https://reviews.llvm.org/D86540