[libcxx-commits] [PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 16 10:30:26 PDT 2020


ldionne added a subscriber: hans.
ldionne added a comment.

@hans Is there still time to cherry-pick this to the 11 release?

In D31413#2277198 <https://reviews.llvm.org/D31413#2277198>, @eastig wrote:

> I don't mind.
> Just to check,  in PR28954 it is mentioned the solution based on 'init_priority' works for Linux. What about other platforms?
> The idea was to fall back to the conservative method if the attribute is not supported by a compiler. Maybe, as an option a warning can be issued.

Eric Fiselier said the attribute worked on all compilers we support, including clang-cl. So as long as you compile the library with a supported compiler, my understanding is that it should work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D31413/new/

https://reviews.llvm.org/D31413



More information about the libcxx-commits mailing list