[libcxx-commits] [PATCH] D87323: Bring atomic header closer to C++20

[JF Bastien via Phabricator via libcxx-commits]

jfb added a subscriber: STL_MSFT.
jfb added a comment.

Generally this looks good, but I didn't go into details.
It would be good to have an MS person like @STL_MSFT check that the std tests match, at least for what they've implemented.



================
Comment at: libcxx/include/atomic:1255
   _Tp __temp;
   __cxx_atomic_assign_volatile(__temp, __a->__a_value);
+  bool __ret = (memcmp(&__temp, __expected, sizeof(_Tp)) == 0);
----------------
Unrelated to your change, but the lock could come after `__temp`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87323/new/

https://reviews.llvm.org/D87323