[libcxx-commits] [PATCH] D87054: Include libcxx and libcxxabi tests in check-all

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

As discussed offline, the issue is that `add_lit_testsuite` does `set_property(GLOBAL APPEND PROPERTY LLVM_LIT_PARAMS ${ARG_PARAMS})`, which means that all test suites (e.g. libcxxabi and libunwind) will now share the same Lit invocation parameters. However, if those have been configured differently, like if libcxx wants to run with `--param enable_exceptions=False` but libcxxabi wants to run with `--param enable_exceptions=True`, that won't be respected. There will be a single top-level Lit invocation that will get passed both `--param enable_exceptions=False` and `--param enable_exceptions=True`, and whichever appears last (I think) will be used.

The problem really is that we make one global Lit invocation with `check-all`. Instead, one approach might be to `add_dependencies(check-all check-cxx)` when the `check-all` target exists, but that isn't free of issues either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87054/new/

https://reviews.llvm.org/D87054