[libcxx-commits] [PATCH] D86598: [libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY

Tue Sep 1 01:04:41 PDT 2020

Nicu added a comment.

In D86598#2248202 <https://reviews.llvm.org/D86598#2248202>, @ldionne wrote:

> This seems to have been reverted in
>
>   commit a19fd1aab519ccec18654f76a01b0345880c5200
>   Author: Mikhail Maltsev <mikhail.maltsev at arm.com>
>   Date:   Thu Aug 27 16:47:18 2020 +0100
>   
>       Revert "[libcxx] Fix compile for BUILD_EXTERNAL_THREAD_LIBRARY"
>   
>       This reverts commit 3b71f91558ff8b569199547efe800cb501c3cf94.
>   
>       The commit is breaking some build bots.
>
> Has it been committed again with a fix? I don't see it -- what's the status?

Hi Louis, this is the revision that fixes the compilation with EXTERNAL_LIBRARY (https://reviews.llvm.org/D86773), without changes to the visibility in the operator. As you fixed that already.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86598/new/

https://reviews.llvm.org/D86598