[libcxx-commits] [PATCH] D87950: Make libc++ headers "just work" on all Android versions.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I really want to avoid going down the road of adding more of these `#if`s to our headers for importing stuff from the C library headers. It's a pain to maintain and it is very prone to creating conflicts with downstream patches. I've personally been keeping these `#if`s downstream only to avoid creating too much burden on the upstream, until we have a better solution. We have been working on an implementation of the feature that was discussed here: http://lists.llvm.org/pipermail/cfe-dev/2020-June/066038.html, which would remove the need for these `#if`s in the `<cXXXX>` headers.

I would rather wait until we have that Clang feature before we move forward.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87950/new/

https://reviews.llvm.org/D87950