[libcxx-commits] [PATCH] D90021: [libcxx] [libcxxabi] Set flags for visibility when statically linking libcxxabi into libcxx for windows

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 26 10:25:04 PDT 2020


rnk added a comment.

I read the commit message, and what you said makes sense to me. As I understand it, there are two supported configs on Windows:

- Shared: libc++ and libc++abi as one DLL.
- Static: both libc++ and libc++abi are static libraries.

Is it possible to simplify the cmake conditionals if we add some checks for that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90021/new/

https://reviews.llvm.org/D90021



More information about the libcxx-commits mailing list