[libcxx-commits] [PATCH] D89945: [libcxx] [test] Use path::operator== instead of PathEq in the path.append test

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 22 03:39:31 PDT 2020


mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

This checks equality regardless of directory separator form, as the reference contains literal forward slashes, but the tested output will contain the preferred separator on windows.

Skip test cases that include backslashes when on windows, as they're treated as a separator.

This does weaken the test somewhat - but makes the test much more manageable with alternative path separators.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89945

Files:
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.append.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89945.299914.patch
Type: text/x-patch
Size: 3869 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201022/576db4ae/attachment-0001.bin>


More information about the libcxx-commits mailing list