[libcxx-commits] [libcxx] 69c2087 - [libc++] Fix compiler-rt build by copying libc++ headers to <build>/include

[Louis Dionne via libcxx-commits]

> On Oct 21, 2020, at 19:05, Nico Weber <thakis at chromium.org> wrote:
> 
> Not sure I'd call this an "implementation detail". The build dir used to have clang in 'bin/clang', lib stuff in 'lib/...', and this in 'include/...'. That's also the dir layout when installing, and it means that clang's built-in search logic would find libc++ headers before. That seems like a bad thing to break?


I wasn't aware this was a convention at a point -- I must have missed it, or it isn't something that's widely known.

In all cases, I would argue that the proper way to create something that looks like an installation root is to actually perform the installation to a directory using the scripts that CMake gives you. You can even do it from within CMake itself. That way, you are guaranteed that the proper installation steps are performed, for example:
- Setting up the config_site header properly
- Replacing libc++.so by a linker script on platforms that do that

So it looks like I broke something that is (or once was) a "contract", however I definitely think that contract should be more explicit. I'll see what I can do to improve the situation there.

Louis