[libcxx-commits] [PATCH] D89041: [libc++] Include <__config_site> from <__config>

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 21 13:45:49 PDT 2020


mstorsjo added a comment.

This seems to have broken my builds of libcxxabi+libcxx. I'm building them standalone (i.e. configuring each of libunwind, libcxxabi and libcxx individually with cmake), and I've used to set `LIBCXXABI_LIBCXX_INCLUDES` to point at the libcxx include dir, but that cmake option is removed now. I presume the `cxx-headers` dependency is supposed to take care of that, but that only works when building them all with one cmake invocation (part of full llvm build, or part of runtimes build)?

Could we keep `LIBCXXABI_LIBCXX_INCLUDES` (in order not to break existing scripts), or what's the best way forward here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89041/new/

https://reviews.llvm.org/D89041



More information about the libcxx-commits mailing list