[libcxx-commits] [PATCH] D89865: [libcxx] [test] Mark filesystem braced_init test as requiring libc++

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 21 03:48:07 PDT 2020


mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

This test fails on both MS STL and libstdc++, with errors like these:

error: use of overloaded operator '=' is ambiguous (with operand types 'std::filesystem::path' and 'void')

  p = {};
  ~ ^ ~~

note: candidate function

  path& operator=(path&&) noexcept = default;

note: candidate function

  path& operator=(const path&) = default;

note: candidate function

  path& operator=(string_type&& _Source) noexcept /* strengthened */ {

I'm not really familiar with these bits of modern C++ though to see what differs to libc++'s header, where this test succeeds, and whether that aspect is mandated by the standard though.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89865

Files:
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/braced_init.pass.cpp


Index: libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/braced_init.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/braced_init.pass.cpp
+++ libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/braced_init.pass.cpp
@@ -8,6 +8,8 @@
 
 // UNSUPPORTED: c++03
 
+// REQUIRES: libc++
+
 // <filesystem>
 
 // class path


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89865.299630.patch
Type: text/x-patch
Size: 474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201021/9ca6511d/attachment.bin>


More information about the libcxx-commits mailing list