[libcxx-commits] [PATCH] D89535: [libcxx] [test] Split the file_time_type synopsis test

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 20 14:04:55 PDT 2020


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with the suggested change.



================
Comment at: libcxx/test/std/input.output/filesystems/fs.filesystem.synopsis/file_time_type_resolution.pass.cpp:24
+
+void test_time_point_resolution_and_range() {
+  using namespace fs;
----------------
Can you rename to `file_time_type_resolution.compile.pass.cpp` and just use:

```
using namespace fs;
using Dur = file_time_type::duration;
using Period = Dur::period;
ASSERT_SAME_TYPE(Period, std::nano);
```

No need for `main` or `test_time_point_resolution_and_range()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89535/new/

https://reviews.llvm.org/D89535



More information about the libcxx-commits mailing list