[libcxx-commits] [PATCH] D89676: [libcxx] [test] Mark tests that require specific allocation behaviours as libcpp only

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 19 05:35:55 PDT 2020


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: dexonsmith.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/string_alloc.pass.cpp:9
 
-// UNSUPPORTED: c++03
+// UNSUPPORTED: c++03, !libc++
 
----------------
It's a nit, but can you please instead use `// REQUIRES: libc++` above the `c++03` requirement -- I find it easier to read that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89676/new/

https://reviews.llvm.org/D89676



More information about the libcxx-commits mailing list