[libcxx-commits] [PATCH] D89679: [libcxx] [test] Mark tests for to_time_t as libcpp specific

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 19 05:29:20 PDT 2020


ldionne added subscribers: EricWF, ldionne.
ldionne added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:388
     file_time_type ftime = last_write_time(file);
-    TEST_CHECK(Clock::to_time_t(ftime) == file_write_time.tv_sec);
+    LIBCPP_ONLY(TEST_CHECK(Clock::to_time_t(ftime) == file_write_time.tv_sec));
     TEST_CHECK(CompareTime(ftime, file_write_time));
----------------
I think you're right, it's only specified as a member of `system_clock`. @EricWF  is there a reason why you provided it `to_time_t` for your `_FilesystemClock`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89679/new/

https://reviews.llvm.org/D89679



More information about the libcxx-commits mailing list