[libcxx-commits] [PATCH] D89675: [libcxx] [test] Add LIBCPP_ONLY() around another test for an implementation detail

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 19 02:45:00 PDT 2020


mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89675

Files:
  libcxx/test/std/input.output/filesystems/fs.enum/enum.perm_options.pass.cpp


Index: libcxx/test/std/input.output/filesystems/fs.enum/enum.perm_options.pass.cpp
===================================================================
--- libcxx/test/std/input.output/filesystems/fs.enum/enum.perm_options.pass.cpp
+++ libcxx/test/std/input.output/filesystems/fs.enum/enum.perm_options.pass.cpp
@@ -33,7 +33,7 @@
   typedef std::underlying_type<E>::type UT;
   static_assert(!std::is_convertible<E, UT>::value, "");
 
-  static_assert(std::is_same<UT, unsigned char >::value, ""); // Implementation detail
+  LIBCPP_ONLY(static_assert(std::is_same<UT, unsigned char >::value, "")); // Implementation detail
 
   typedef check_bitmask_type<E, E::replace, E::nofollow> BitmaskTester;
   assert(BitmaskTester::check());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89675.298968.patch
Type: text/x-patch
Size: 733 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201019/0464cce6/attachment.bin>


More information about the libcxx-commits mailing list