[libcxx-commits] [PATCH] D89588: [libcxx] [test] Remove a duplicate definition of _CRT_SECURE_NO_WARNINGS

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/support/msvc_stdlib_force_include.h:17
-    // Silence warnings about CRT machinery.
-    #define _CRT_SECURE_NO_WARNINGS
-
----------------
CaseyCarter wrote:
> Instead of striking this, could we instead define it conditionally to 1:
> ```
> #ifndef _CRT_SECURE_NO_WARNINGS
> #define _CRT_SECURE_NO_WARNINGS 1
> #endif // _CRT_SECURE_NO_WARNINGS
>  ```
> to preserve use cases that don't involve `config.py`?
Sure, that's fine by me as well. And no new ifdef is needed if we just add the `1` to the definition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89588/new/

https://reviews.llvm.org/D89588