[libcxx-commits] [PATCH] D89588: [libcxx] [test] Remove a duplicate definition of _CRT_SECURE_NO_WARNINGS

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo updated this revision to Diff 298752.
mstorsjo added a comment.
Herald added a subscriber: arichardson.

Also remove a fixme comment regarding this define - it can't be removed from config.py.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89588/new/

https://reviews.llvm.org/D89588

Files:
  libcxx/test/support/msvc_stdlib_force_include.h
  libcxx/utils/libcxx/test/config.py


Index: libcxx/utils/libcxx/test/config.py
===================================================================
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -272,7 +272,6 @@
         compile_flags_str = self.get_lit_conf('compile_flags', '')
         self.cxx.compile_flags += shlex.split(compile_flags_str)
         if self.target_info.is_windows():
-            # FIXME: Can we remove this?
             self.cxx.compile_flags += ['-D_CRT_SECURE_NO_WARNINGS']
             # Required so that tests using min/max don't fail on Windows,
             # and so that those tests don't have to be changed to tolerate
Index: libcxx/test/support/msvc_stdlib_force_include.h
===================================================================
--- libcxx/test/support/msvc_stdlib_force_include.h
+++ libcxx/test/support/msvc_stdlib_force_include.h
@@ -13,9 +13,6 @@
 // MSVC standard library.
 
 #ifndef _LIBCXX_IN_DEVCRT
-    // Silence warnings about CRT machinery.
-    #define _CRT_SECURE_NO_WARNINGS
-
     // Avoid assertion dialogs.
     #define _CRT_SECURE_INVALID_PARAMETER(EXPR) ::abort()
 #endif // _LIBCXX_IN_DEVCRT


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89588.298752.patch
Type: text/x-patch
Size: 1154 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201016/f49a6712/attachment-0001.bin>