[libcxx-commits] [PATCH] D89057: Add the C++17 <memory_resource> header (mono-patch)

Fri Oct 16 13:44:28 PDT 2020

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

You seem to be missing several `// UNSUPPORTED: c++11, c++14` annotations from your test. This is a C++17 feature, let's just provide it in C++17. This will also make the test suite more portable (other implementations might not ship `pmr` before C++17).

================
Comment at: libcxx/include/__memory_resource_base:14
+
+#ifndef _LIBCPP_CXX03_LANG
+
----------------
This is a C++17 addition, so I would use `#if _LIBCPP_STD_VER > 14`.

================
Comment at: libcxx/include/memory_resource:14
+
+#ifndef _LIBCPP_CXX03_LANG
+
----------------
This is a C++17 addition, so I would use #if _LIBCPP_STD_VER > 14.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89057/new/

https://reviews.llvm.org/D89057