[libcxx-commits] [PATCH] D89537: [libcxx] [test] Fix string type handling in a few fairly trivial class.path tests

Martin Storsjö via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 16 03:44:10 PDT 2020


mstorsjo created this revision.
mstorsjo added a reviewer: libc++.
Herald added a project: libc++.
Herald added 1 blocking reviewer(s): libc++.
mstorsjo requested review of this revision.

Use string() for convenience for testing where possible, but keep using native() for move tests where we want to check that no allocations are made, constructing a reference fs::path::string_type instead.

Use the right value_type in a few places.

Make the synop test check for the right types and for the expected preferred separator.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89537

Files:
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/copy.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.assign/move.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.construct/copy.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.construct/move.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.construct/source.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/c_str.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/native.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.member/path.native.obs/operator_string.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.nonmember/path.io.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/path.nonmember/swap.pass.cpp
  libcxx/test/std/input.output/filesystems/class.path/synop.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89537.298587.patch
Type: text/x-patch
Size: 9208 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20201016/3b7d9d00/attachment.bin>


More information about the libcxx-commits mailing list