[libcxx-commits] [PATCH] D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/utils/libcxx/test/config.py:624
             '--execdir %T',
+            '--test-executable %t.exe',
             '--codesign_identity "{}"'.format(codesign_ident),
----------------
What would you say of passing some kind of regex or glob pattern to `--test-executable` instead? I find it weird that we're passing the path to something that might not exist here.

Instead, if we had an argument like `--test-executable-pattern` (or similar), the contract could be that "the executor treats any file that matches this pattern as being a test executable". And when there's no such file, it's okay.

This would also accommodate passing several test executables, although I don't think we have a use case for this at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83429/new/

https://reviews.llvm.org/D83429