[libcxx-commits] [PATCH] D88727: vector (iterator, iterator) constructor doesn't deduce second arg

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added a comment.

Is this a problem unique to `vector`?  Do the other containers have the same constructor? Do those constructors have the same issue?
Checking ... `list` does not seem to have this problem. `deque` does not either. `forward_list` does not either.

<deque> has the following code:

  template <class _InputIter>
      deque(_InputIter __f, _InputIter __l,
            typename enable_if<__is_cpp17_input_iterator<_InputIter>::value>::type* = 0);
  template <class _InputIter>
      deque(_InputIter __f, _InputIter __l, const allocator_type& __a,
            typename enable_if<__is_cpp17_input_iterator<_InputIter>::value>::type* = 0);

I don't think that making `vector` different from the other containers is the right approach.  Then again, I'm not 100% sure why the existing code is failing - so I should look at that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88727/new/

https://reviews.llvm.org/D88727