[libcxx-commits] [PATCH] D88818: [libc++][FreeBSD] XFAIL tests that need __atomic_* libcalls on older versions

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 13 10:01:51 PDT 2020


ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

What is the error that you're seeing? How are you running the test suite?

It looks like you are running against the system library, right? If so, we already have a feature to handle these sorts of `XFAIL`s, it's `with_system_cxx_lib=<system>`. It's only used by macOS for the time being, but it can (and should) be used by other systems as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88818/new/

https://reviews.llvm.org/D88818



More information about the libcxx-commits mailing list