[libcxx-commits] [PATCH] D86540: [libcxxabi, libunwind] support running tests in standalone mode

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I love this. Some comments but looks almost ready to go.



================
Comment at: libcxxabi/CMakeLists.txt:40
+
+  if (EXISTS "${LIBCXXABI_LIBCXX_CMAKE_PATH}")
+    list(APPEND CMAKE_MODULE_PATH "${LIBCXXABI_LIBCXX_CMAKE_PATH}")
----------------
This check isn't necessary -- we already have a similar one at the very top of the file.


================
Comment at: libunwind/CMakeLists.txt:37
   else()
-    set(LLVM_INCLUDE_TESTS OFF)
+    message(FATAL_ERROR "${LIBUNWIND_LIBCXX_CMAKE_PATH} not found. This is not a supported configuration.")
   endif()
----------------
Can you add this at the very top of the file instead?


```
if (NOT IS_DIRECTORY "${CMAKE_CURRENT_LIST_DIR}/../libcxx")
  message(FATAL_ERROR "libunwind requires being built in a monorepo layout with libcxx available")
endif()
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86540/new/

https://reviews.llvm.org/D86540