[libcxx-commits] [PATCH] D83429: [libc++] [test] Introduce the `--test-executable` option in ssh.py

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Oct 11 11:13:13 PDT 2020


arichardson added a comment.

If this flag was also added to run.py, it could also be used to implement wrapper commands (such as running the test under QEMU/GDB/Valgrind) in a much less hacky way. I used a different approach in D88899 <https://reviews.llvm.org/D88899> and D88903 <https://reviews.llvm.org/D88903>, but if there was a way to identify the test executable, we could implement the wrapper command feature simply by passing `--test-executable` (instead of --wrapper-command) to ensure code signing signs the test and not the wrapper. The wrapper command is then simply the first argument after the `--`.
If the --test-executable (or --test-executables if we could have multiple executables?) is not set, it simply defaults to the current behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83429/new/

https://reviews.llvm.org/D83429



More information about the libcxx-commits mailing list