[libcxx-commits] [PATCH] D89110: [libcxx][dsl] Reduce number of feature checks

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added a comment.

In D89110#2322098 <https://reviews.llvm.org/D89110#2322098>, @ldionne wrote:

> What's the time gain like for doing this?

Without this change:

  Benchmark #1: ./bin/llvm-lit -v --no-execute projects/libcxx/test/libcxx/selftest/dsl/
    Time (mean ± σ):      2.621 s ±  0.029 s    [User: 1.455 s, System: 0.847 s]
    Range (min … max):    2.593 s …  2.688 s    10 runs

With the patch applied:

  Benchmark #1: ./bin/llvm-lit -v --no-execute projects/libcxx/test/libcxx/selftest/dsl/
    Time (mean ± σ):      2.466 s ±  0.019 s    [User: 1.387 s, System: 0.779 s]
    Range (min … max):    2.435 s …  2.500 s    10 runs

So it appears to save ~150ms or about 6% of the total run time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89110/new/

https://reviews.llvm.org/D89110