[libcxx-commits] [PATCH] D87171: Implement P0919R3

Fri Oct 9 14:35:48 PDT 2020

zoecarver added a comment.

> I am also sorry about duplicating the work. I looked at the cxx2a_status.html and saw that it is not taken.

No worries. I probably should have updated the status.

> I hope the process will become clearer to me and I hope we will avoid such situations in future.

I'm not sure we have a very good process right now. Especially for those without commit access. I know not everyone agrees with this idea but, I am still holding out hope for a unified platform for issues, status, and patches. It's at least a year out but maybe one day we'll be able to keep track of what papers need to be implemented on GitHub then people can easily assign those issues to themselves and link them to PRs.

Also, if you search for the paper number on phab you can see if anyone's already got a patch up.

> And regarding __cpp_lib_generic_unordered_lookup feature macro question. At least, I didn't add it. If it should be added let me figure out how to do that.

Just add a `#define __cpp_lib_generic_unordered_lookup 202010L` in `<version>`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87171/new/

https://reviews.llvm.org/D87171