[libcxx-commits] [PATCH] D89003: [libc++] Add caching for feature-detection Lit tests

Fri Oct 9 07:29:50 PDT 2020

arichardson added a comment.

In D89003#2321810 <https://reviews.llvm.org/D89003#2321810>, @ldionne wrote:

> In D89003#2321797 <https://reviews.llvm.org/D89003#2321797>, @arichardson wrote:
>
>> I think copy.deepcopy() (as I used in D89109 <https://reviews.llvm.org/D89109>) should be a bit faster than pickle and also provide the same guarantee?
>
> Oops, I'm sloppy -- I had not seen your D89109 <https://reviews.llvm.org/D89109> yet. Sorry about that. Does deepcopy allow us to use a dict? If not, I think I still prefer dumping to a string for simplicity. Speed isn't a huge concern here if we compare pickling to running the processes.

My bad, I should have linked the revision in this comment. I think doing the dict lookup is better since the cache ends up holding about 60 elements in some cases.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89003/new/

https://reviews.llvm.org/D89003