[libcxx-commits] [PATCH] D88188: [libc++] Use runtime rather then compile-time glibc version check
Petr Hosek via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Oct 8 09:15:38 PDT 2020
phosek marked an inline comment as done.
phosek added inline comments.
================
Comment at: libcxx/test/std/localization/locale.categories/category.monetary/locale.moneypunct.byname/thousands_sep.pass.cpp:129
#else
+ const char sep = ' ';
// FIXME libc++ specifically works around \u00A0 by translating it into
----------------
ldionne wrote:
> On non-glibc, this changed the `wsep` from `L' ' ` to `L'\u00A0'` if I read this correctly.
Thanks for catching this, addressed in rG4424d2428aebd3537d3f5a3625acb65edfb5d11f.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88188/new/
https://reviews.llvm.org/D88188
More information about the libcxx-commits
mailing list