[libcxx-commits] [PATCH] D88843: [libcxx] Don't treat Windows specially with visibility annotations

Wed Oct 7 15:21:44 PDT 2020

phosek added a comment.

In D88843#2315203 <https://reviews.llvm.org/D88843#2315203>, @ldionne wrote:

> In D88843#2313287 <https://reviews.llvm.org/D88843#2313287>, @phosek wrote:
>
>> In D88843#2312961 <https://reviews.llvm.org/D88843#2312961>, @ldionne wrote:
>>
>>> In D88843#2312944 <https://reviews.llvm.org/D88843#2312944>, @phosek wrote:
>>>
>>>> Possible solution would be to allow per-target `__config` which is something I was going to propose separately since we have other use cases for it. That is, we would share headers across targets, but each target would have its own `__config`. This approach is already used by libstdc++. I have a local prototype and the implementation is pretty straightforward.
>>>
>>> Do you mean `__config`, or `__config_site`?
>>
>> `__config_site` is the only file that differs across targets, but we always concat it with `__config` so I assumed we're going to have a per-target copy of `__config`, but we could make this even granular by keeping them separate and using `#include <__config_site>` guarded by `#if __has_include(<__config_site>) ... #endif` inside `__config`. Would that be preferable?
>
> Actually, I have a patch that changes libc++ to use `#include <__config_site>`. I've been wanting to do that for a while. Let me put it up for review.

I have uploaded my change as D89013 <https://reviews.llvm.org/D89013>, which in turn depends on D83911 <https://reviews.llvm.org/D83911> and D88452 <https://reviews.llvm.org/D88452>. Once your change is up for review, I'll rebase my change on top of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88843/new/

https://reviews.llvm.org/D88843