[libcxx-commits] [PATCH] D83911: [libcxx] Move the libc++ header paths to the common location

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 7 15:20:11 PDT 2020


phosek added inline comments.


================
Comment at: libcxx/include/CMakeLists.txt:258
     install(FILES ${file}
-      DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}include/c++/v1/${dir}
+      DESTINATION ${LIBCXX_INSTALL_HEADER_PREFIX}${LIBCXX_INSTALL_HEADER_DIR}/${dir}
       COMPONENT ${CXX_HEADER_TARGET}
----------------
ldionne wrote:
> Why don't we hardcode `${LIBCXX_INSTALL_HEADER_DIR}` as `include/c++/v1` here? I don't see the point in having this additional indirection.
See D89013 where I build the per-target config support on top of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83911/new/

https://reviews.llvm.org/D83911



More information about the libcxx-commits mailing list