[libcxx-commits] [PATCH] D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS

Zbigniew Sarbinowski via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 6 19:19:50 PDT 2020


zibi added a comment.

Marshall, I really want to hear your opinion about the need to call `pthread_equal()`. 
See my last comment. The `'operator==` of `__thread_id`  is calling `__libcpp_thread_id_equal` passing two arguments of type `__libcpp_thread_id` which have integral type. Therefore, as it is now it's perfectly fine to do operator equal as apposed to call `pthread_equal()`.

In a meantime I experimented with `'__libcpp_thread_t` so we can actually call `pthread_equal()`.  I introduced `__thread_t'` class in place of `__thread_id` and all the ripple effect code associated with it. Let me know if you want to proceed this route and/or see my draft first.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88599/new/

https://reviews.llvm.org/D88599



More information about the libcxx-commits mailing list