[libcxx-commits] [PATCH] D88899: [libcxx][executors] Add a --wrapper-command flag to prepend a command

Alexander Richardson via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 6 10:02:35 PDT 2020


arichardson added inline comments.


================
Comment at: libcxx/utils/run.py:27
     parser.add_argument('--env', type=str, nargs='*', required=False, default=dict())
+    parser.add_argument('--wrapper-command', type=str, required=False, default=None)
     parser.add_argument("command", nargs=argparse.ONE_OR_MORE)
----------------
ldionne wrote:
> This is like an executor within an executor. Is there a reason why you don't simply write a separate executor that does the things you need?
> 
> I think it would be good to leave these basic executors simple -- the whole thing was meant to be extended by writing new executors, not by making the existing executors more complex.
That would work well for the local executor, but adding the prefix to the ssh executor means I'd also have to duplicate the ssh executor (that's the one I really want this feature for). I feel like adding this command line flag is simpler than duplicating every executor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88899/new/

https://reviews.llvm.org/D88899



More information about the libcxx-commits mailing list