[libcxx-commits] [PATCH] D88843: [libcxx] Don't treat Windows specially with visibility annotations

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D88843#2312799 <https://reviews.llvm.org/D88843#2312799>, @mstorsjo wrote:

> And to be clear, this isn't about manually defining `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` while building libc++ itself; it needs to be defined whenever user code includes libc++ headers.

Let's add a proper `LIBCXX_DISABLE_VISIBILITY_ANNOTATIONS` option and `config_define_if(LIBCXX_DISABLE_VISIBILITY_ANNOTATIONS _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS)` like we do for other `__config_site` macros. Then, you can configure your build with `-DLIBCXX_DISABLE_VISIBILITY_ANNOTATIONS` and remove the platform specific logic from libc++'s CMake.

WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88843/new/

https://reviews.llvm.org/D88843