[libcxx-commits] [PATCH] D88843: [libcxx] Don't treat Windows specially with visibility annotations

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added subscribers: thieta, mstorsjo.
mstorsjo added a comment.

I'm a "vendor" building libc++ for windows, both statically and dynamically, and without this, I'll need to manually inject a `#define _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` into the installed headers somehow.

At least in my experience, code generation with headers lacking dllimport attributes, but linking against an import library for a DLL, works much better than building user code with dllimport but linking against a static library. (Yes, the linker can sometimes generate the `__imp_` stubs for dllimport linking against oneself, but iirc it doesn't work flawlessly for things like libc++.)

Also cc @thieta


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88843/new/

https://reviews.llvm.org/D88843