[libcxx-commits] [PATCH] D88718: [libcxx] Port to NuttX(https://nuttx.apache.org/) RTOS

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: libcxx/include/__config:1127
       defined(__NetBSD__) || \
+      defined(__NuttX__) || \
       defined(__linux__) || \
----------------
How does `__NuttX__` get defined?


================
Comment at: libcxx/include/support/nuttx/xlocale.h:17
+
+#define _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE
+
----------------
This change probably belongs in `__config`


================
Comment at: libcxx/include/support/nuttx/xlocale.h:24
+#undef _NEWLIB_VERSION
+
+#endif // __NuttX__
----------------
Why all the `#undef`s?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88718/new/

https://reviews.llvm.org/D88718