[libcxx-commits] [PATCH] D92212: Make libcxx work according to Clang C++ Status if -fchar8_t is passed

[Michael Schellenberger Costa via Phabricator via libcxx-commits]

miscco added inline comments.


================
Comment at: libcxx/include/__config:956
 #define _LIBCPP_NO_HAS_CHAR8_T
 #endif
 // Deprecation macros.
----------------
mclow.lists wrote:
> georgthegreat wrote:
> > As of this PR, _LIBCPP_NO_HAS_CHAR8_T became a simple negation of __cpp_char8_t.
> > 
> > The configuration might become easier to read upon replacing all invocation of these options with feature testing macro.
> I'm a big fan of keeping the libc++-specific macro.  
Could you name a benefit that vendor specific macros have over the universal ones?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92212/new/

https://reviews.llvm.org/D92212